Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tuple item leading zeroes #470 #510

Merged
merged 2 commits into from
Aug 11, 2021
Merged

Tuple item leading zeroes #470 #510

merged 2 commits into from
Aug 11, 2021

Conversation

andy-ow
Copy link
Contributor

@andy-ow andy-ow commented Aug 11, 2021 •
edited by sbillig
Loading

What was wrong?

issue #470
Leading zeros in tuple indexes should not be allowed.

How was it fixed?

Check for leading zeros in tuple indexes (like item00 or item001). Small change in expressions.rs + tests.

To-Do

  • OPTIONAL: Update Spec if applicable

  • Add entry to the release notes (may forgo for trivial changes)

  • Clean up commit history

@sbillig
Copy link
Collaborator

sbillig commented Aug 11, 2021

@andy-ow Looks great, thanks! Could you add a simple newsfragments/510.bugfix.md describing what was fixed? (Add a trailing newline on that file, or the lint check will reject it, btw)

There's also a minor conflict with the master branch now that I've merged #509. Would you mind rebasing?

@g-r-a-n-t g-r-a-n-t changed the title Tupple item leading zeroes #470 Tuple item leading zeroes #470 Aug 11, 2021
@sbillig sbillig force-pushed the tupple_item_leading_zeroes_#470 branch from f255a2d to f2789af Compare August 11, 2021 21:58
@sbillig
Copy link
Collaborator

sbillig commented Aug 11, 2021

@andy-ow I handled the chores I mentioned above; you weren't taking too long, I'd just like to get this PR merged in prior to #468, which would have caused a lot more merge conflicts

@sbillig sbillig merged commit b4d819f into ethereum:master Aug 11, 2021
@sbillig sbillig mentioned this pull request Dec 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andy-ow @sbillig